Better explain that form types should be unique in the application #5076
Conversation
javiereguiluz
commented
Mar 11, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4960 |
| The ``getName()`` method returns the identifier of this form "type". These | ||
| identifiers must be unique in the application and, unless you want to override | ||
| a built-in type, they should be different from the default Symfony types. | ||
| Consider prefixing your types with ``app_`` to avoid identifier collisions. |
There was a problem hiding this comment.
should this become a best practice ?
| Consider prefixing your types with ``app_`` to avoid identifier collisions. | ||
|
|
||
| This new class contains all the directions needed to create the task form. It can | ||
| be used to quickly build a form object in the controller: |
There was a problem hiding this comment.
We need to colons here. Otherwise, the following code block won't be recognized.
|
Thanks for your review. Everything has been fixed/updated and I've created a separate issue (#5077) to discuss about introducing a new best practice for Symfony forms. |
| identifiers must be unique in the application. Unless you want to override | ||
| a built-in type, they should be different from the default Symfony types | ||
| and from any type defined by a third-party bundle installed in you application. | ||
| Consider prefixing your types with ``app_`` to avoid identifier collisions. |
There was a problem hiding this comment.
In the best practices, we use app. (dot instead of underscore) for service names. Should we follow this convention here too?
There was a problem hiding this comment.
I agree with you. I've just updated the PR with your suggestion.
| identifiers must be unique in the application. Unless you want to override | ||
| a built-in type, they should be different from the default Symfony types | ||
| and from any type defined by a third-party bundle installed in you application. | ||
| Consider prefixing your types with ``app.`` to avoid identifier collisions. |
There was a problem hiding this comment.
You are right. It's done in 0eb149b. Thanks.
| The ``getName()`` method returns the identifier of this form "type". These | ||
| identifiers must be unique in the application. Unless you want to override | ||
| a built-in type, they should be different from the default Symfony types | ||
| and from any type defined by a third-party bundle installed in you application. |
|
Thanks Javier! I don't like needing this warning, but it makes sense. It does beg the question though - should we prefix all of these with app_ in the docs? |
…plication (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Better explain that form types should be unique in the application | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4960 Commits ------- 7a78532 Fixed a minor grammar issue 0eb149b Recommend app_ instead of app. as form type prefix 52a5551 Recommend a better way to standardize application form types d47e751 Fixed syntax issues and provided more information 12b77af Better explain that form types should be unique in the application
|
Ha, yes I see that's exactly what you're asking in #5077 :) |
